Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procs: 0.8.5 -> 0.8.9 #68186

Merged
merged 1 commit into from Sep 6, 2019
Merged

procs: 0.8.5 -> 0.8.9 #68186

merged 1 commit into from Sep 6, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 6, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

@ofborg ofborg bot requested a review from dalance September 6, 2019 06:29
dalance
dalance approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@dalance dalance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsam marsam merged commit 79303d4 into NixOS:master Sep 6, 2019
@marsam marsam deleted the update-procs branch September 6, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalance dalance dalance approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @dalance @jonringer