Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carp: unstable-2018-09-15 -> 0.3.0 #68155

Merged
merged 1 commit into from Nov 23, 2019
Merged

carp: unstable-2018-09-15 -> 0.3.0 #68155

merged 1 commit into from Nov 23, 2019

Conversation

illfygli
Copy link
Contributor

@illfygli illfygli commented Sep 5, 2019

Motivation for this change

Carp has it's first proper release: https://github.com/carp-lang/Carp/releases/tag/v0.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jluttine

@risicle
Copy link
Contributor

risicle commented Sep 6, 2019

nix-review builds macos 10.13, binary works.

jluttine
jluttine reviewed Sep 7, 2019
View reviewed changes
pkgs/development/compilers/carp/default.nix
};

buildDepends = [ makeWrapper ];

executableHaskellDepends = with haskellPackages; [
HUnit blaze-markup blaze-html split cmdargs
HUnit blaze-markup blaze-html split cmdargs ansi-terminal cmark
edit-distance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious to learn: How did you figure out what dependencies to add? And what would be a good way to check that this set of dependencies contains everything that's needed and nothing unnecessary? Is there any easy way for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am new to Nix/NixOS, but the way I did it (after discovering that changing the revision caused the build to fail) was to check what changed in the .cabal file since the previous revision.

@jluttine
Copy link
Member

jluttine commented Sep 7, 2019

Just for reference for anyone interested: In order to run the simple example on https://github.com/carp-lang/Carp#a-very-small-example, you need the following environment:

nix-shell -p carp SDL2 pkgconfig xlibs.libXinerama xlibs.libXext xlibs.libXcursor xlibs.libXi xlibs.libXrandr xlibs.libXxf86vm xlibs.libXScrnSaver

I tested compiling and running the example, everything seemed to work. So this PR looks good to me.

@c0bw3b c0bw3b merged commit a03e315 into NixOS:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluttine jluttine jluttine left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@illfygli @risicle @jluttine @c0bw3b @Janik-Haag