Test more CSSStyleSheet error cases #18892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly to get coverage of calling `deleteRule()` on an empty style, which was added and reverted with the wrong exception type: #16342 #16353 The test is split into more subtests, but the order is kept the same and only `assert_throws` tests were added in between tests to avoid having to change anything. For this reason the order of subtests is a bit haphazard.
|
Alright, https://wpt.fyi/results/css/cssom/CSSStyleSheet.html?diff&filter=ADC&run_id=293320003&run_id=297180006 shows the benfit of splitting into subtests. It's now clear the problem is likely that |
|
https://wpt.fyi/results/css/cssom/CSSStyleSheet.html?sha=78579a9fe9&label=pr_head shows Chrome and Firefox too, they pass all the tests. @youennf FYI in case you're tracking Safari-specific failures. |
lilles
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to get coverage of calling
deleteRule()on an emptystyle, which was added and reverted with the wrong exception type:
#16342
#16353
The test is split into more subtests, but the order is kept the same
and only
assert_throwstests were added in between tests to avoidhaving to change anything. For this reason the order of subtests is a
bit haphazard.