Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bayescan: init at 2.1 #68191

Merged
merged 3 commits into from Jan 9, 2020
Merged

bayescan: init at 2.1 #68191

merged 3 commits into from Jan 9, 2020

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Sep 6, 2019

Motivation for this change

Tool used into my computing center

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
Copy link
Contributor

risicle commented Sep 6, 2019

To get this building on macos (possibly all llvm platforms), you just need to... add another replacement for the Makefile:

substituteInPlace Makefile --replace "-static" "" \
  --replace "g++" "c++"

and provide it with llvmPackages.openmp:

  buildInputs = stdenv.lib.optional stdenv.cc.isClang llvmPackages.openmp;

Given this it builds for me, macos 10.13 & non-nixos linux x86_64.

@bzizou
Copy link
Contributor Author

bzizou commented Oct 3, 2019

up?

@veprbl
Copy link
Member

veprbl commented Jan 9, 2020

@GrahamcOfBorg build bayescan

@veprbl veprbl merged commit f7a4e4a into NixOS:master Jan 9, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 10, 2020
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
(cherry picked from commit f7a4e4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants