Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.picos: init at 1.2.0 #64529

Merged
merged 1 commit into from Sep 22, 2019
Merged

pythonPackages.picos: init at 1.2.0 #64529

merged 1 commit into from Sep 22, 2019

Conversation

tobiasBora
Copy link
Contributor

Motivation for this change

Introduce the picos library, a "user friendly Python API to several conic and integer programming solvers, very much like YALMIP or CVX under MATLAB."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobiasBora tobiasBora requested a review from FRidh as a code owner July 9, 2019 14:59
@worldofpeace
Copy link
Contributor

ping @tobiasBora

@worldofpeace worldofpeace changed the title picos: init at 1.2.0 pythonPackages.picos: init at 1.2.0 Sep 22, 2019
worldofpeace
worldofpeace approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've correct your commit message to the contribution guidelines and squashed everything together.

@worldofpeace worldofpeace merged commit ed9745e into NixOS:master Sep 22, 2019
@tobiasBora
Copy link
Contributor Author

Thank you !

@worldofpeace
Copy link
Contributor

@tobiasBora Thank you too for contributing ✨

@Artturin Artturin mentioned this pull request Jul 30, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@FRidh FRidh FRidh requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tobiasBora @worldofpeace @FRidh @tadeokondrak @JohnAZoidberg