Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/icingaweb: Fix module path; Add test #64407

Merged
merged 1 commit into from Aug 19, 2019
Merged

nixos/icingaweb: Fix module path; Add test #64407

merged 1 commit into from Aug 19, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg test icingaweb2

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Thank you.

@mmahut mmahut merged commit 3b62589 into NixOS:master Aug 19, 2019
@dasJ dasJ deleted the icingaweb-test branch August 24, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants