Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.36 #64414

Merged
merged 2 commits into from Jul 13, 2019
Merged

Rust 1.36 #64414

merged 2 commits into from Jul 13, 2019

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Jul 7, 2019

Motivation for this change

Update Rust from 1.35.0 to 1.36.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This works around 'failed to open:
/homeless-shelter/.cargo/.package-cache' with Rust 1.36 even when
we're using 'cargo --frozen'.
@Mic92
Copy link
Member

Mic92 commented Jul 8, 2019

On aarch64-linux I can build fd. On x86_64-linux I also build firefox.

@Mic92
Copy link
Member

Mic92 commented Jul 8, 2019

We also need someone to verify macOS:

$ nix-review pr -p fd 64414

cc @alyssais

@xrelkd
Copy link
Contributor

xrelkd commented Jul 8, 2019

(Not sure if it is proper to post here but it is also related to Rust.)

I notice that the buildType option in pkgs/build-support/rust/default.nix is not working.
However, this issue was solved by @AtkinsChang in PR #63762 2 weeks ago.

Could anyone help to review #63762, if possible?
Thank you very much!!

@killercup
Copy link
Member

Just tested nix-review pr -p fd 64414 on macOS (10.13.6) and it failed to build libuv. If someone can point out how to fix that I can then test this PR :)

Full log
$ git fetch --force https://github.com/NixOS/nixpkgs staging:refs/nix-review/0 pull/64414/head:refs/nix-review/1
$ git worktree add /Users/pascal/.cache/nix-review/pr-64414-1/nixpkgs da96a4119feeaaa4df32788aa28422a5703743b4
Preparing worktree (detached HEAD da96a4119fe)
Checking out files: 100% (19235/19235), done.
HEAD is now at da96a4119fe Merge staging-next into staging
$ git merge --no-commit 33723434a888b7b9ce5a9b35dba2e77baf254109
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /Users/pascal/.cache/nix-review/pr-64414-1/build.nix
builder for '/nix/store/ixi45fzrk8f88645m7yljbb7c2lii3z2-libuv-1.30.0.drv' failed with exit code 77; last 10 log lines:
  checking for gawk... gawk
  checking whether make sets $(MAKE)... yes
  checking whether make supports nested variables... yes
  checking build system type... x86_64-apple-darwin17.7.0
  checking host system type... x86_64-apple-darwin17.7.0
  checking for gcc... clang
  checking whether the C compiler works... no
  configure: error: in `/private/var/folders/n3/dkk459k908lcmkzwcmq0tcv00000gn/T/nix-build-libuv-1.30.0.drv-0/source':
  configure: error: C compiler cannot create executables
  See `config.log' for more details
cannot build derivation '/nix/store/9v6j83km7iqi987br54pxa24a6d5wdz9-cmake-3.14.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/b6gp4m0j7dv8zaxjlj8kipaq23yb93s5-libc++abi-5.0.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5k38981vns104fnwc57zqc5yrgqql83w-libgit2-0.27.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/a552wcvz3xnzb5j78hn27f8m7s54grcs-llvm-5.0.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7pg9g8zq8s3jjibzwnc4lb67y42hgznm-clang-5.0.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/fs82ncia8zqzf1lb6r8qdm4hrpjpywbq-compiler-rt-5.0.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ylpklhqdwa2c5pb47aa6p7k6zn1r9c32-libc++-5.0.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/2fpvx6nx5knzfpw6j2ik9a6x20xv0z90-clang-wrapper-5.0.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/l8s5vj5r8yakn72dbyfp0bwq4hpvlqbi-stdenv-darwin.drv': 1 dependencies couldn't be built
builder for '/nix/store/32021z2hayx9hfk6ghw34s1j3kbn53dw-git-2.22.0.drv' failed with exit code 2; last 10 log lines:
                   ^const char      *inet_ntop(int, const void *, char *, socklen_t);

                   ^
  1 warning and 1 error generated.
  make: *** [Makefile:2375: fuzz-commit-graph.o] Error 1
  make: *** Waiting for unfinished jobs....
  1 warning and 1 error generated.
  1 warning and 1 error generated.
  make: *** [Makefile:2375: fuzz-pack-idx.o] Error 1
  make: *** [Makefile:2375: fuzz-pack-headers.o] Error 1
cannot build derivation '/nix/store/vp2ykh5vbrwa6asj15fhnhzdm6d0njrr-rustc-1.36.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/hjx6d1hplsj7pvzzs5si9p8vj1iw67gr-cargo-1.36.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/gs7kwwl9d7j2gv71vvzil3wgarfhrbkm-fd-7.3.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ha06df49zgzg20zd10m91cs8611z33d2-env.drv': 1 dependencies couldn't be built
[0 built (2 failed)]
error: build of '/nix/store/ha06df49zgzg20zd10m91cs8611z33d2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64414
1 package failed to build:
fd

[0.0 MiB DL]
error: build log of '/nix/store/gs7kwwl9d7j2gv71vvzil3wgarfhrbkm-fd-7.3.0.drv' is not available
No packages were successfully build, skip nix-shell
$ git worktree prune

@vcunat
Copy link
Member

vcunat commented Jul 11, 2019

libuv and git failures seem very unlikely to be related to this PR.

@edolstra edolstra merged commit b1375da into NixOS:staging Jul 13, 2019
@edolstra
Copy link
Member Author

I've merged this since the macOS failures seem to be caused by something unrelated.

@vcunat
Copy link
Member

vcunat commented Jul 23, 2019

Darwin build succeeded on Hydra: https://hydra.nixos.org/build/96691406

@edolstra edolstra deleted the rust-1.36 branch August 15, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants