[UserTimingL3] {}, null, undefined passed to start treated as 0 #17735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1691862
branch
5 times, most recently
from
d381743
to
2ba9f71
Compare
According to the spec (https://w3c.github.io/user-timing/#measure-method), UserTimingL3 API has the second argument being: optional (DOMString or PerformanceMeasureOptions) startOrMeasureOptions This indicates that the arg cannot distinguish between: 1. null 2. {} 3. undefined 4. { invalidDictProperty } According to the spec: 3.1.3 measure() method... 3. Compute start time as follows.. 4. Otherwise, let start time be 0. When these indistinguishable values are passed, they should be interpreted as start time being 0. Bug: 953840 Change-Id: I052a7823d9ae8b27056f53f04a26fcc93421db75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691862 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675873}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1691862
branch
from
2ba9f71
to
f87a2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec (https://w3c.github.io/user-timing/#measure-method),
UserTimingL3 API has the second argument being:
optional (DOMString or PerformanceMeasureOptions) startOrMeasureOptions
This indicates that the arg cannot distinguish between:
According to the spec:
3.1.3 measure() method...
3. Compute start time as follows..
4. Otherwise, let start time be 0.
When these indistinguishable values are passed, they should be
interpreted as start time being 0.
Bug: 953840
Change-Id: I052a7823d9ae8b27056f53f04a26fcc93421db75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691862
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675873}