iproute: 5.1.0 -> 5.2.0 #64454
Merged
iproute: 5.1.0 -> 5.2.0 #64454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Not a lot of big new features in this release. Just the usual array of small fixes across the board." [0] File changes: None nix path-info -S: 5.1.0 46637048 5.2.0 46627312 [0]: https://www.spinics.net/lists/netdev/msg584562.html
jonringer
reviewed
Jul 10, 2019
There was a problem hiding this comment.
After 2 days, my nix-review finally finished. A lot of the failed builds seem to be broken on master and likely to be false regressions.
I don't have enough willpower to determine if they are regressions :).
Nix-review output
[4696 built (20 failed), 3468 copied (2 failed) (23941.7 MiB), 13810.8 MiB DL]
error: build of '/nix/store/mb2dygflywgl6ypydf6rfp77f1vajvxl-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64454
19 package are marked as broken and were skipped:
chronos gimpPlugins.focusblur gimpPlugins.texturize gnomeExtensions.system-monitor openmodelica python37Packages.cntk uzbl vimprobable2-unwrapped xenPackages.xen_4_5-light xenPackages.xen_4_5-slim xenPackages.xen_4_5-vanilla xfce.xfce4-dict-plugin xfce.xfce4-notes-plugin xfce.xfce4_dict_plugin xfce.xfce4_notes_plugin xfce4-12.xfce4-dict-plugin xfce4-12.xfce4-notes-plugin xfce4-12.xfce4_dict_plugin xfce4-12.xfce4_notes_plugin
67 package failed to build:
Sylk beegfs cntk discover flatpak flatpak-builder gimp-with-plugins gimpPlugins.gimplensfun gimpPlugins.ufraw gnome-builder gnome3.gnome-boxes gnome3.gnome-contacts gnome3.gnome-software shotwell ike kmymoney libguestfs libguestfs-with-appliance libsForQt511.khotkeys libvirt-glib libvmi lutris memtest86-efi minishift python27Packages.baselines python27Packages.cntk python27Packages.dask-jobqueue python27Packages.dask-mpi python27Packages.distributed python27Packages.guestfs python27Packages.neurotools python27Packages.streamz python37Packages.baselines python37Packages.dask-jobqueue python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.dftfit python37Packages.distributed python37Packages.guestfs python37Packages.lammps-cython python37Packages.streamz qemu_xen qemu_xen-light qemu_xen_4_10 qemu_xen_4_10-light quodlibet quodlibet-full quodlibet-without-gst-plugins quodlibet-xine quodlibet-xine-full qutebrowser rednotebook spark ufraw vagrant virt-viewer virtinst virtmanager xdg-desktop-portal xdg-desktop-portal-gtk xen xen-light xen-slim xen_4_10-light xen_4_10-slim xen_4_10 xfce.xfce4-vala-panel-appmenu-plugin
|
I did perform a few manual and automatic tests - this update should be fine :) @jonringer Thanks :) That was probably a bit overkill but it never hurts. And yes, these packages are most likely false positives that where already broken before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Not a lot of big new features in this release. Just the usual array of
small fixes across the board." 0
File changes:
None
nix path-info -S:
5.1.0 46637048
5.2.0 46627312
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)WIP as the release is tagged as "vv5.2.0" and not "v5.2.0" (I've notified the maintainer) and might be re-tagged.