Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbixctl: init at unstable-2019-07-06 #64396

Merged
merged 1 commit into from Jul 10, 2019
Merged

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 6, 2019

Motivation for this change

init at unstable-2019-07-06

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Jul 8, 2019

@mmahut It looks like you accidentally included some exiv related work in here.

@mmahut
Copy link
Member Author

mmahut commented Jul 10, 2019

@aanderse oops, sorry. Rebased.

@aanderse
Copy link
Member

Time to test out my new super powers and see if this build on darwin ...

@GrahamcOfBorg build zabbixctl

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review shows no issues. Perfect formatting. I built and ran locally the previous commit with no noticeable issues. LGTM 👍

@aanderse aanderse merged commit 5827ff2 into NixOS:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants