Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockbook: init at 0.3.1 #64399

Merged
merged 1 commit into from Jul 16, 2019
Merged

blockbook: init at 0.3.1 #64399

merged 1 commit into from Jul 16, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 6, 2019

Motivation for this change

init at 0.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg requested changes Jul 8, 2019
View reviewed changes
pkgs/servers/blockbook/default.nix Show resolved Hide resolved
pkgs/servers/blockbook/default.nix Outdated Show resolved Hide resolved
pkgs/servers/blockbook/default.nix Outdated Show resolved Hide resolved
@JohnAZoidberg
Copy link
Member

Builds fine and blockbook -h works fine on NixOS x64.

@mmahut
Copy link
Member Author

mmahut commented Jul 10, 2019

@JohnAZoidberg Thank you for your review, rebased.

@mmahut
Copy link
Member Author

mmahut commented Jul 10, 2019

@GrahamcOfBorg build blockbook

@worldofpeace worldofpeace merged commit 75777d6 into NixOS:master Jul 16, 2019
@mmahut mmahut deleted the blockbook branch July 16, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @JohnAZoidberg @worldofpeace