Update FakeXRDeviceInterface to match webxr-test-api #17740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1692038
branch
4 times, most recently
from
347ae67
to
5e49100
Compare
This updates the FakeXRDeviceInterface to support newly added methods in the webxr-test-api: * simulateVisibilityChange * setBoundsGeometry * setLocalToFloorLevelTransform * clearLocalToFloorLevelTransform and supports the setting of boundsCoordinates and localToFloorLevelTransform in FakeXRDeviceInit. The Bounds and LocalToFloorLevelTransform functions already existed on internal tests, and as such a few of the tests that were ready were ported to external wpts. Note that simulateInputSourceConnection and disconnect will be implemented by future work. Bug: 979316 Change-Id: Idfb8bb631bfc1f1cb13b571a90b1a41b4a6fe518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692038 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#676087}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1692038
branch
from
5e49100
to
238f2df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the FakeXRDeviceInterface to support newly added methods in
the webxr-test-api:
and supports the setting of boundsCoordinates and
localToFloorLevelTransform in FakeXRDeviceInit.
The Bounds and LocalToFloorLevelTransform functions already existed on
internal tests, and as such a few of the tests that were ready were
ported to external wpts.
Note that simulateInputSourceConnection and disconnect will be
implemented by future work.
Bug: 979316
Change-Id: Idfb8bb631bfc1f1cb13b571a90b1a41b4a6fe518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692038
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676087}