Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-buildtools: 0.22.0 -> unstable-2019-06-21 #64537

Closed
wants to merge 1 commit into from
Closed

bazel-buildtools: 0.22.0 -> unstable-2019-06-21 #64537

wants to merge 1 commit into from

Conversation

u-quark
Copy link
Contributor

@u-quark u-quark commented Jul 9, 2019 •
edited

Motivation for this change

Continuation from #63856

Update to HEAD of master. There are a few nice features there, so it might make sense to go directly to HEAD.

I used go2nix to produce the files, even though I patched default.nix to include the meta info.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@u-quark u-quark requested a review from Profpatsch as a code owner July 9, 2019 17:40
@u-quark u-quark mentioned this pull request Jul 9, 2019
Closed
10 tasks
@u-quark
Copy link
Contributor Author

u-quark commented Jul 9, 2019

@Profpatsch @uri-canva Can you have a look please?

uri-canva
uri-canva reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@uri-canva uri-canva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'm not sure about taking head over the latest tagged version. The last tag was only a month ago and the previous one was one month before that so it's unlikely we'll have to wait very long until the next tag.

pkgs/development/tools/build-managers/bazel/buildtools/default.nix
@@ -1,16 +1,16 @@
{ stdenv, buildGoPackage, fetchFromGitHub }:
{ stdenv, buildGoPackage, fetchgit, fetchhg, fetchbzr, fetchsvn }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchhg, fetchbzr, fetchsvn don't seem to be used, were they added by go2nix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they were added by go2nix.

@u-quark
Copy link
Contributor Author

u-quark commented Jul 10, 2019

@uri-canva True, but there is no reason to wait either. There are a few useful features in the latest commits and this will not break any other package.

@u-quark
Copy link
Contributor Author

u-quark commented Jul 10, 2019

@uri-canva Looks like you might get your wish after all: bazelbuild/buildtools@0ce0811#commitcomment-34252722

@u-quark u-quark mentioned this pull request Jul 22, 2019
Merged
10 tasks
@u-quark
Copy link
Contributor Author

u-quark commented Jul 22, 2019

Closing in favor of #65277: bumping to an newer upstream version release.

@u-quark u-quark closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-canva uri-canva uri-canva left review comments

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@u-quark @uri-canva