New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
foliate: init at 1.5.3 #64536
foliate: init at 1.5.3 #64536
Conversation
I was able to run the application but I couldn't load any eBooks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems development has moved quickly since you've opened this.
https://github.com/johnfactotum/foliate/releases/tag/1.5.0
To adapt to that release you probably should add espeak
and use wrapPython
to patch
the python module included.
8d2666a
to
d200f31
Compare
It looks like the issue I ran into is a problem with foliate and not this package. I was able to reproduce the same issue on my Arch machine trying to open the same ebook. I tried again with some other epub samples and everything seems to be working as expected. I have no issue opening the book in calibre, so I'm not really sure why foliate has an issue with this specific file... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think these deps are needed.
Application still functions when I remove them.
These comments from last review were unaddressed #64536 (comment) #64536 (comment)
webkitgtk | ||
gsettings-desktop-schemas | ||
gobject-introspection | ||
cairo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cairo |
gsettings-desktop-schemas | ||
gobject-introspection | ||
cairo | ||
libgee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libgee |
gobject-introspection | ||
cairo | ||
libgee | ||
pantheon.granite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pantheon.granite |
cairo | ||
libgee | ||
pantheon.granite | ||
libxml2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libxml2 |
* whitespace * use license (gpl3Plus) in source headers * drop convenience alias, let upstream be unfriendly if it wants
Thank you @worldofpeace, I got those deps from looking at meson files that were checking for them optionally.... but not seeing them now, so maybe goofed on which repo I was looking at or something :3. Anyway, outstanding issues / unresolved issues AFAIK:
|
I can't lie that I've done that very often. I quickly realize I probably should close the other 50 tabs 😄
It appears you accidentally removed
This is how they use it I think I may have tried this and wasn't a way for
I think it wants those optional programs like Case of preference to use hardcode patch or a wrapper. |
I just started writing a derivation for this, but then someone told me about this PR. Would love to see this in master. Is anything holding this up? Can I help? |
Meanwhile version 2.0 is released. It is really a great and cool GTK program! |
Feel free to take over, we will be glad to review. |
2.2.0 is out. |
I'm closing this PR, if anyone wants to continue the work please open a new one. |
For testing purpose I continued this package in my NUR repository. You can try the package |
Motivation for this change
"A simple and modern GTK eBook reader".
Took some wrangling to get gjs to run without having problems finding
'main' or some resource, see linked issues from code for some details of
similar. Does seem to work nicely now, though! ^_^
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)