Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foliate: init at 1.5.3 #64536

Closed
wants to merge 4 commits into from
Closed

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 9, 2019

Motivation for this change

"A simple and modern GTK eBook reader".

Took some wrangling to get gjs to run without having problems finding
'main' or some resource, see linked issues from code for some details of
similar. Does seem to work nicely now, though! ^_^

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kira-bruneau
Copy link
Contributor

I was able to run the application but I couldn't load any eBooks.

foliate

file:///nix/store/3mggjk8rq27s5cha58xgm7gn4fmsy2c1-foliate-1.4.0/share/com.github.johnfactotum.Foliate/assets/epub.js:3435:10: CONSOLE ERROR Not allowed to load local resource: file:///home/kira/Documents/Outlander%20Series%20by%20Diana%20Gabaldon/EPUB/META-INF/container.xml
file:///nix/store/3mggjk8rq27s5cha58xgm7gn4fmsy2c1-foliate-1.4.0/share/com.github.johnfactotum.Foliate/assets/epub.js:3435:10: CONSOLE ERROR Not allowed to request resource
file:///nix/store/3mggjk8rq27s5cha58xgm7gn4fmsy2c1-foliate-1.4.0/share/com.github.johnfactotum.Foliate/assets/epub.js:3435:10: CONSOLE ERROR XMLHttpRequest cannot load file:///home/kira/Documents/Outlander%20Series%20by%20Diana%20Gabaldon/EPUB/META-INF/container.xml due to access control checks.
file:///nix/store/3mggjk8rq27s5cha58xgm7gn4fmsy2c1-foliate-1.4.0/share/com.github.johnfactotum.Foliate/assets/epub.js:3435:10: CONSOLE ERROR Not allowed to load local resource: file:///home/kira/Documents/Outlander%20Series%20by%20Diana%20Gabaldon/EPUB/META-INF/container.xml
file:///nix/store/3mggjk8rq27s5cha58xgm7gn4fmsy2c1-foliate-1.4.0/share/com.github.johnfactotum.Foliate/assets/epub.js:3435:10: CONSOLE ERROR Not allowed to request resource
file:///nix/store/3mggjk8rq27s5cha58xgm7gn4fmsy2c1-foliate-1.4.0/share/com.github.johnfactotum.Foliate/assets/epub.js:3435:10: CONSOLE ERROR XMLHttpRequest cannot load file:///home/kira/Documents/Outlander%20Series%20by%20Diana%20Gabaldon/EPUB/META-INF/container.xml due to access control checks.
Error sending IPC message: Broken pipe

@worldofpeace worldofpeace self-assigned this Jul 19, 2019
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems development has moved quickly since you've opened this.

https://github.com/johnfactotum/foliate/releases/tag/1.5.0

To adapt to that release you probably should add espeak and use wrapPython to patch
the python module included.

pkgs/applications/office/foliate/default.nix Show resolved Hide resolved
pkgs/applications/office/foliate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/foliate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/foliate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/foliate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/foliate/default.nix Show resolved Hide resolved
@dtzWill dtzWill changed the title foliate: init at 1.4.0 foliate: init at 1.5.2 Jul 20, 2019
@kira-bruneau
Copy link
Contributor

It looks like the issue I ran into is a problem with foliate and not this package. I was able to reproduce the same issue on my Arch machine trying to open the same ebook. I tried again with some other epub samples and everything seems to be working as expected.

I have no issue opening the book in calibre, so I'm not really sure why foliate has an issue with this specific file...

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think these deps are needed.

Application still functions when I remove them.

These comments from last review were unaddressed #64536 (comment) #64536 (comment)

webkitgtk
gsettings-desktop-schemas
gobject-introspection
cairo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cairo

gsettings-desktop-schemas
gobject-introspection
cairo
libgee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
libgee

gobject-introspection
cairo
libgee
pantheon.granite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pantheon.granite

cairo
libgee
pantheon.granite
libxml2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
libxml2

pkgs/applications/office/foliate/default.nix Show resolved Hide resolved
* whitespace
* use license (gpl3Plus) in source headers
* drop convenience alias, let upstream be unfriendly if it wants
@dtzWill
Copy link
Member Author

dtzWill commented Jul 26, 2019

Thank you @worldofpeace, I got those deps from looking at meson files that were checking for them optionally.... but not seeing them now, so maybe goofed on which repo I was looking at or something :3.

Anyway, outstanding issues / unresolved issues AFAIK:

  • package/wrap the python bits that appear to be useful for interacting with Kindle formats?
  • wrap or patch in path for espeak(-ng)

@dtzWill dtzWill changed the title foliate: init at 1.5.2 foliate: init at 1.5.3 Jul 26, 2019
@worldofpeace
Copy link
Contributor

Thank you @worldofpeace, I got those deps from looking at meson files that were checking for them optionally.... but not seeing them now, so maybe goofed on which repo I was looking at or something :3.

I can't lie that I've done that very often. I quickly realize I probably should close the other 50 tabs 😄

Anyway, outstanding issues / unresolved issues AFAIK:

It appears you accidentally removed gdk_pixbuf in 3be211e.

package/wrap the python bits that appear to be useful for interacting with Kindle formats?

This is how they use it

I think I may have tried this and wasn't a way for wrapPython to work for it. (not in site-packages)

wrap or patch in path for espeak(-ng)

I think it wants those optional programs like dict etc. in $PATH

Case of preference to use hardcode patch or a wrapper.

@JonathanReeve
Copy link
Contributor

I just started writing a derivation for this, but then someone told me about this PR. Would love to see this in master. Is anything holding this up? Can I help?

@onny
Copy link
Contributor

onny commented Apr 7, 2020

Meanwhile version 2.0 is released. It is really a great and cool GTK program!

@jtojnar
Copy link
Contributor

jtojnar commented Apr 7, 2020

Feel free to take over, we will be glad to review.

@sikmir
Copy link
Member

sikmir commented Jun 13, 2020

2.2.0 is out.

@worldofpeace
Copy link
Contributor

I'm closing this PR, if anyone wants to continue the work please open a new one.

@onny
Copy link
Contributor

onny commented Aug 14, 2020

For testing purpose I continued this package in my NUR repository. You can try the package nur.repos.onny.foliate if you want :) I've packaged version 2.4.2. Still not sure which features might be missing or bugs still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants