Allow trailing slash in test_get_current_url_file_protocol #17679
Conversation
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
|
But Firefox doesn’t do this? Smells like a web compat issue that should be fixed in Firefox/Chrome. |
|
Looks like this particular subject isn't covered by URL standards. If not covered by the standards, shouldn't both (legitimate) implementations be accepted and considered valid? In any case, I believe that since this issue is a Firefox/Chrome standards issue, it is out of the scope of webdrivers (and therefore out of scope for this webdriver test) and shouldn't be considered during this test. If chromedriver adheres to the W3C Get Current URL spec (which it does), it should pass the test. |
|
My intention wasn’t to block this patch for any of those reasons. I wanted confirmation that we weren’t applying a workaround for what might conceivably be a web compatibility issue. This is somewhat important to clarify because WebDriver is used extensively to test other web standards. Anyway, I asked around and found this in the Fetch standard on scheme fetch:
That means the behaviour is implementation defined and, as you suggested, that the test should pass regardless what the browser returns. |
…web-platform-tests#17679) Fetcing file:// protocol is not standardised which means the test has to be more forgiving of the URL returned.
Chrome automatically adds a trailing slash if the suffix of the file protocol is a directory. Chromedriver currently fails this test due to this trailing slash (the rest of the URL is identical). This changelist considers urls with and without a trailing slash correct.