Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserTimingL3] Throw TypeError on negative time stamp #17736

Merged
merged 1 commit into from Jul 11, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 9, 2019

According to the spec (https://w3c.github.io/user-timing/):

  1. "If markOptions's startTime is negative, throw a TypeError.",
  2. "If mark is negative, throw a TypeError." when "Convert a mark to a timestamp"

The CL is to add these two checks accordingly.

Bug: 953865
Change-Id: I8475870cc883dc8c3d3d4f3e65a9d5a0a2189a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691871
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676266}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1691871 branch 2 times, most recently from 9313f83 to 052f202 Compare July 10, 2019 16:05
According to the spec (https://w3c.github.io/user-timing/):
1. "If markOptions's startTime is negative, throw a TypeError.",
2. "If mark is negative, throw a TypeError." when "Convert a mark to a timestamp"

The CL is to add these two checks accordingly.

Bug: 953865
Change-Id: I8475870cc883dc8c3d3d4f3e65a9d5a0a2189a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691871
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676266}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants