Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix polybarFull #64441

Merged
merged 1 commit into from Jul 24, 2019
Merged

fix polybarFull #64441

merged 1 commit into from Jul 24, 2019

Conversation

justinwoo
Copy link
Member

this build cannot support both wirelesstools and libnl at the same time,
and also cannot support both i3 and i3gaps.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@justinwoo
Copy link
Member Author

This is a fix for #63193.

I naively thought that the CI caught breakages from newly introduced derivations. I should've run :b polybarFull manually

@justinwoo
Copy link
Member Author

this also means the "polybarFull" package makes a few choices, rather than to actually be completely "Full". Maybe that's fine with everyone.

@FRidh
Copy link
Member

FRidh commented Jul 10, 2019 •
edited

Why not change the default values instead of removing the options? And add assertions.

@justinwoo
Copy link
Member Author

Sure, I could just change them. What do you mean by adding assertions? There are some in the derivation already, but they do not fail the build.

@justinwoo
fix polybarFull
34c3c11 
this build cannot support both wirelesstools and libnl at the same time,
and also cannot support both i3 and i3gaps.
@ttuegel
Copy link
Member

ttuegel commented Jul 24, 2019

There are some in the derivation already, but they do not fail the build.

They fail evaluation locally. They probably do not fail on Hydra because that would break evaluation for every package, IIUC.

@ttuegel ttuegel merged commit b12c895 into NixOS:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinwoo @FRidh @ttuegel