kodi: 18.1 -> 18.3 #64383
kodi: 18.1 -> 18.3 #64383
Conversation
|
@GrahamcOfBorg build kodi |
| }; | ||
|
|
||
| cmakeProto = fetchurl { | ||
| url = "https://raw.githubusercontent.com/pramsey/libght/master/cmake/modules/CheckPrototypeExists.cmake"; |
There was a problem hiding this comment.
Since this is on master it isn't stable.
Is it possible you could just add this file into nixpkgs?
There was a problem hiding this comment.
That repo hasn't changed in 4 years but you are of course correct - it isn't stable. I'll make it reference the specific commit instead. I don't like adding build files to nixpkgs if we can at all avoid it. This really should go upstream.
|
The fixes here are certainly rather manual. I'm guessing there's no way around it, but maybe reports upstream could help? |
That's absolutely the way to go, yes. |
|
This isn't meant to be closed. Sorry guys. |
|
I'm not sure why the build timed out, but I have been using this version for quite a while without problems. |
Motivation for this change
Upstream update from 18.1 to 18.3 (bug fix release).
There are some minor changes to make the libdvd{css,nav,read} dependencies build as well (now they all do), but the kodi build system requires some changes in order to actually use them instead of force building them during the main kodi build.
Cc: @domenkozar @titanous @edwtjo @sephalon
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)