Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: fixup darwin build #64500

Closed
wants to merge 1 commit into from
Closed

mesa: fixup darwin build #64500

wants to merge 1 commit into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jul 9, 2019

by a patch suggested upstream

Motivation for this change

Blocking lots of darwin builds. See previous discussion from #63875 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
mesa: fixup darwin build
d4e194a 
by a patch suggested upstream
@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Jul 9, 2019
@vcunat
Copy link
Member Author

vcunat commented Jul 9, 2019

@GrahamcOfBorg build mesa

@vcunat vcunat mentioned this pull request Jul 9, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

@vcunat Should we go for #63912 instead?

@vcunat
Copy link
Member Author

vcunat commented Jul 9, 2019

Right, I didn't notice. This isn't sufficient to fix the build anyway.

@vcunat vcunat closed this Jul 9, 2019
@vcunat vcunat deleted the p/mesa-darwin branch June 11, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vcunat @worldofpeace