Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubikey-personalization: 1.19.3 -> 1.20.0 #64508

Merged
merged 1 commit into from Jul 18, 2019
Merged

yubikey-personalization: 1.19.3 -> 1.20.0 #64508

merged 1 commit into from Jul 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 9, 2019

Motivation for this change

https://developers.yubico.com/yubikey-personalization/Release_Notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 9, 2019

I starting having some issues with my yubikey this afternoon, not enough information to narrow things down yet but whereas I believe ykinfo -a previously reported information I'm now seeing it report no yubikey found. So probably best to at least have this vetted by someone w/hardware and I'm optimistic my issue will be sorted soon... but let's wait a bit for now :).

@mmahut
Copy link
Member

mmahut commented Jul 10, 2019

Moving myself to this version as part of the testing effort, given I'm using yubikey daily.

@yorickvP
Copy link
Contributor

I'm getting Yubikey core error: no yubikey present, but this also happens on 1.19.3. Maybe ykinfo does not support this yubikey version. ykman from yubikey-manager does work.

@yorickvP
Copy link
Contributor

Update: ykinfo only works when you have OTP enabled. It works for me as expected with 1.20.0

@dtzWill
Copy link
Member Author

dtzWill commented Jul 18, 2019

Oh, d'oh! Yes I recently-ish disabled OTP so that explains that. Good catch, thanks for sharing!

❤️

@dtzWill dtzWill merged commit 7f8bbe3 into NixOS:master Jul 18, 2019
@dtzWill dtzWill deleted the update/yubikey-personalization-1.20.0 branch July 18, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mmahut @yorickvP