Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial-builders: support '/' in writeTextDir #64421

Merged
merged 1 commit into from Jul 16, 2019
Merged

trivial-builders: support '/' in writeTextDir #64421

merged 1 commit into from Jul 16, 2019

Conversation

rycee
Copy link
Member

@rycee rycee commented Jul 7, 2019

Before one would get the following error

nix-repl> pkgs.writeTextDir "share/my-file" "foo"
error: invalid character '/' in name 'share/my-file'

Fixes #50347

CC @flokli

@rycee rycee force-pushed the bugfix/writeTextDir-with-slash branch from e2ba3c8 to c97552e Compare July 7, 2019 19:32
@FRidh
Copy link
Member

FRidh commented Jul 13, 2019

I suggest also replacing <name> in the docstring example with either <path> or the value of path of the example.

@rycee
trivial-builders: support '/' in writeTextDir
6900a32 
Before one would get the following error

    nix-repl> pkgs.writeTextDir "share/my-file" "foo"
    error: invalid character '/' in name 'share/my-file'

Fixes NixOS#50347
@rycee rycee force-pushed the bugfix/writeTextDir-with-slash branch from c97552e to 6900a32 Compare July 13, 2019 15:04
@rycee
Copy link
Member Author

rycee commented Jul 13, 2019

@FRidh Good point, I've updated to include the real path, like in the writeScriptBin docs.

danbst
danbst approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@danbst danbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@danbst danbst merged commit 70d6271 into NixOS:master Jul 16, 2019
@rycee rycee deleted the bugfix/writeTextDir-with-slash branch July 17, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyball lilyball lilyball approved these changes

@danbst danbst danbst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkgs.writeTextDir doesn't allow slashes
4 participants
@rycee @FRidh @lilyball @danbst