pythonPackages.myfitnesspal: init at 1.13.3 #64422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python2Packages.myfitnesspal python2Packages.measurement python3Packages.myfitnesspal python3Packages.measurement |
bhipple
commented
Jul 7, 2019
| postPatch = '' | ||
| sed -i 's/keyring>=.*/keyring/' requirements.txt | ||
| sed -i 's/keyrings.alt>=.*/keyrings.alt/' requirements.txt | ||
| ''; |
There was a problem hiding this comment.
Both modules pass all of their test cases, but I also verified manually that the package works; keyring appears to increment major versions very frequently so I just stripped the version bound entirely rather than loosening it to what we currently have.
jonringer
reviewed
Jul 7, 2019
|
squash commits so there is one per package |
bhipple
force-pushed
the
add/myfitnesspal
branch
from
25d3384
to
b0fd855
Compare
|
Commits now properly squashed per package |
|
Ping @FRidh, I have squashed the commits as requested. I believe this should be ready for merge, but if not let me know and I'm happy to update further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a python library for downloading data from the MyFitnessPal API, which is useful for users who want to chart/graph/visualize their data with other tools, such as seaborn or matplotlib.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)