Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rq: init at 1.1.0 #64525

Merged
merged 1 commit into from Jul 26, 2019
Merged

pythonPackages.rq: init at 1.1.0 #64525

merged 1 commit into from Jul 26, 2019

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Adding a new package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan MrMebelMan requested a review from FRidh as a code owner July 9, 2019 13:37
@MrMebelMan MrMebelMan force-pushed the init/rq branch 3 times, most recently from 889ebe5 to d81c7ea Compare July 9, 2019 17:08
@MrMebelMan
Copy link
Contributor Author

Added tests and quoted the homepage URL

risicle
risicle reviewed Jul 9, 2019
View reviewed changes
pkgs/development/python-modules/rq/default.nix Outdated
sha256 = "0rx8xji473ggmcy40v7lh0a69j4nrb4qrp4kp1766qg0swp37pi2";
};

checkInputs = [ pytest ];
Copy link
Contributor

@risicle risicle Jul 9, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me at least, this finds zero tests, and looking into this project's tests, they appear to heavily depend on having a running redis server (https://github.com/rq/rq/blob/d0884be9296cf2cba2428d5d90cdeda65a550296/run_tests), which is something we can't do. So you're probably better off adding doCheck = false and a comment of something like "tests require a running redis server".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see now... Updated according to your suggestion 🙏

risicle
risicle reviewed Jul 9, 2019
View reviewed changes
pkgs/development/python-modules/rq/default.nix Outdated
};

checkInputs = [ pytest ];
buildInputs = [ mock ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this doesn't appear necessary to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I wasn't quite sure, what does this line do, but thought that it's necessary 🤦‍♂️

@MrMebelMan MrMebelMan force-pushed the init/rq branch 2 times, most recently from 637edf8 to e46a849 Compare July 10, 2019 13:16
@MrMebelMan
Copy link
Contributor Author

removed pytest and updated the commit message to include pythonPackages.

risicle
risicle approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

Works for me, non-nixos linux x86_64

Will be good to have rq.

worldofpeace
worldofpeace suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/rq/rq/releases/tag/v1.1.0 was released.

Can you also format your commit like

pythonPackages.rq: init at 1.0

to match the contributing guidelines?

@MrMebelMan
Copy link
Contributor Author

https://github.com/rq/rq/releases/tag/v1.1.0 was released.

Can you also format your commit like

pythonPackages.rq: init at 1.0

to match the contributing guidelines?

Bumped the version to 1.1.0 and updated the version number in the commit message.
The message format looks fine though! Or am I missing something? 🤔

@worldofpeace worldofpeace changed the title rq: init at 1.0 pythonPackages.rq: init at 1.1.0 Jul 26, 2019
worldofpeace
worldofpeace approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace worldofpeace merged commit b36bed3 into NixOS:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrMebelMan @risicle @worldofpeace