Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Change KRW currency rate #7616

Closed
wants to merge 1 commit into from

Conversation

telk5093
Copy link
Contributor

@telk5093 telk5093 commented Jun 4, 2019

Since 2017, I think because of the Brexit, KRW against GBP has been about 1GBP≒1,500KRW.
OpenTTD is using 1GBP=1,850KRW, which makes very difficult to calculate.

This PR makes 1GBP=1,500KRW which is a close rate in nowadays, and also easier to calculate
But I have no idea if I change openttd's currency rate, please let me aware.

@LordAro
Copy link
Member

LordAro commented Jun 6, 2019

Currency multipliers are only supposed to be very vague approximations - $ & € are both set as 2:1, but nowadays they're much closer to 1:1.

As far as the computer is concerned, 1500 is no harder than 1850 and I'm not sure why you'd need to do any conversion yourself...

@LordAro
Copy link
Member

LordAro commented Jul 7, 2019

Thanks for the contribution, but I'm going to close this for the previously stated reasons - it really doesn't matter what the conversion rate is.

@LordAro LordAro closed this Jul 7, 2019
@telk5093
Copy link
Contributor Author

telk5093 commented Jul 7, 2019

@LordAro I understand, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants