Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More OctoPrint plugins #64419

Merged
merged 6 commits into from Jul 8, 2019
Merged

More OctoPrint plugins #64419

merged 6 commits into from Jul 8, 2019

Conversation

gebner
Copy link
Member

@gebner gebner commented Jul 7, 2019

Motivation for this change

OctoPrint-related updates and plugin additions.

I removed the sarge version override, which silently broke PrintTimeGenius (and also the pip version check in octoprint, but that one doesn't matter).

Tested on a raspberry pi 3b+.

cc maintainer @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@abbradar
Copy link
Member

abbradar commented Jul 8, 2019

@gebner Unfortunately my 3D printer broke some time ago so I don't have any good way for testing OctoPrint. Changes look sensible, so if you have tested it on your hardware you can just merge.

@gebner gebner merged commit dcbc0a4 into NixOS:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants