Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor.xilinx_7series: generate also binary bitfile. #140

Merged
merged 2 commits into from
Jul 7, 2019
Merged

vendor.xilinx_7series: generate also binary bitfile. #140

merged 2 commits into from
Jul 7, 2019

Conversation

peteut
Copy link
Contributor

@peteut peteut commented Jul 7, 2019

whitequark
whitequark reviewed Jul 7, 2019
View reviewed changes
nmigen/vendor/xilinx_7series.py Outdated
@@ -42,7 +42,8 @@ class Xilinx7SeriesPlatform(TemplatedPlatform):
* ``{{name}}_timing.rpt``: Vivado report.
* ``{{name}}_power.rpt``: Vivado report.
* ``{{name}}_route.dcp``: Vivado design checkpoint.
* ``{{name}}.bit``: binary bitstream.
* ``{{name}}.bit``: binary bitstream with metadata.
* ``{{name}}.bin: binary bitstream.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing quote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry.

@codecov
Copy link

codecov bot commented Jul 7, 2019 •
edited

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files          32       32           
  Lines        5111     5111           
  Branches     1106     1106           
=======================================
  Hits         4127     4127           
  Misses        848      848           
  Partials      136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b404d60...51f0363. Read the comment docs.

@whitequark whitequark merged commit 31c54d3 into m-labs:master Jul 7, 2019
@nmigen-issue-migration nmigen-issue-migration mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -bin_file In Vivado Flow?
2 participants
@peteut @whitequark