New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shutdown_player and shutdown_audio_context #279
Conversation
r? @Manishearth |
☔ The latest upstream changes (presumably #281) made this pull request unmergeable. Please resolve the merge conflicts. |
e334613
to
77a42b4
Compare
☔ The latest upstream changes (presumably #285) made this pull request unmergeable. Please resolve the merge conflicts. |
77a42b4
to
b1ae3b3
Compare
r? @ceyusa |
} | ||
} | ||
}; | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we stop this thread?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thread dies as soon as it processes the BackendMsg::Shutdown
channel message.
@bors-servo r+ |
📌 Commit b1ae3b3 has been approved by |
Remove shutdown_player and shutdown_audio_context This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.
☀️ Test successful - checks-travis |
This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.