[FractionalScroll] Fix web tests #17671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1690293
branch
from
d2240e9
to
5f101df
Compare
This CL fixes Blink web tests so that they pass when the Fractional Scroll Offsets flag is enabled. This flag enables fractional offsets on the Blink main thread which breaks some tests because they assume that offsets will be floored. I've modernized two tests: fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html fast/events/scale-and-scroll-div.html The first appears to have been an issue with js-test modifying the page while the second was passing but the PASS string in the -exected.txt had changed to include the factional. Both tests now pass with and without the feature enabled. I removed fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html since it was testing the same thing as scale-and-scroll-div.html. The rest of the tests required changing the layout such that it doesn't cause us to land on fractional offsets (and thus the behavior will be unchanged with and without the flag). Where this was difficult I just allowed for approximate equality. Bug: 414283 Change-Id: Ie03fa06b100fb9946675e921357c1eaebfe6a37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690293 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#676118}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1690293
branch
from
5f101df
to
a64f09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL fixes Blink web tests so that they pass when the Fractional
Scroll Offsets flag is enabled. This flag enables fractional offsets on
the Blink main thread which breaks some tests because they assume that
offsets will be floored.
I've modernized two tests:
fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html
fast/events/scale-and-scroll-div.html
The first appears to have been an issue with js-test modifying the page
while the second was passing but the PASS string in the -exected.txt
had changed to include the factional. Both tests now pass with and
without the feature enabled.
I removed fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html
since it was testing the same thing as scale-and-scroll-div.html.
The rest of the tests required changing the layout such that it doesn't
cause us to land on fractional offsets (and thus the behavior will be
unchanged with and without the flag). Where this was difficult I just
allowed for approximate equality.
Bug: 414283
Change-Id: Ie03fa06b100fb9946675e921357c1eaebfe6a37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690293
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676118}