Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php73: 7.3.6 -> 7.3.7, 7.2.19 -> 7.2.20 [19.03 backport] #64389

Merged
merged 2 commits into from Jul 7, 2019
Merged

php73: 7.3.6 -> 7.3.7, 7.2.19 -> 7.2.20 [19.03 backport] #64389

merged 2 commits into from Jul 7, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 6, 2019

Motivation for this change

#64183
#64326

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Jul 6, 2019
@ofborg ofborg bot requested review from etu and globin July 6, 2019 17:55
@aanderse
Copy link
Member Author

aanderse commented Jul 6, 2019

6 package failed to build:
php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.v8 php72Packages.v8js php73Packages-unit.v8 php73Packages.v8

Unsure if these were broken before... 🤷‍♂️

@etu
Copy link
Contributor

etu commented Jul 7, 2019

@aanderse They seem to have been broken before, I checked out the current releasebranch and tried to build them one by one.

@etu etu merged commit 68fa7ff into NixOS:release-19.03 Jul 7, 2019
@aanderse
Copy link
Member Author

aanderse commented Jul 8, 2019

Thanks again @etu!

@aanderse aanderse deleted the release-19.03 branch July 8, 2019 00:15
@aanderse aanderse mentioned this pull request Jul 8, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @etu