Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jpylyzer: init at 1.18.0, use to enable openjpeg tests #64391

Merged
merged 2 commits into from Jul 17, 2019
Merged

pythonPackages.jpylyzer: init at 1.18.0, use to enable openjpeg tests #64391

merged 2 commits into from Jul 17, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 6, 2019

Motivation for this change

jpylyzer is a "JP2 (JPEG 2000 Part 1) image validator and properties extractor". Added as a python library and application.

openjpeg uses this in its test suite. It seems to me it would be useful to enable the tests for openjpeg, with it being one of those packages with a huge list of reverse dependencies, making nox-review a far less convenient proxy for checking an openjpeg package's correctness.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner July 6, 2019 18:12
@FRidh FRidh changed the base branch from master to staging July 11, 2019 08:01
@FRidh FRidh merged commit 3e5ccd4 into NixOS:staging Jul 17, 2019
pull bot pushed a commit to avitex/nixpkgs that referenced this pull request Jul 26, 2019
@orivej
openjpeg_1: fix build after NixOS#64391
fdf08ce 
That PR has enabled tests for both openjpeg_1 and openjpeg_2, but it did not
support the tests in openjpeg_1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @FRidh