Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saml2aws: 2.10.0 -> 2.15.0 #64468

Merged
merged 1 commit into from Jul 11, 2019
Merged

saml2aws: 2.10.0 -> 2.15.0 #64468

merged 1 commit into from Jul 11, 2019

Conversation

pmyjavec
Copy link

@pmyjavec pmyjavec commented Jul 9, 2019 •
edited

Motivation for this change

Bump to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto
teto requested changes Jul 9, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to update the sha256 hash in fetchFromGitHub else it won't match the new bersion.
You didn't realize because nix had the hash in cache and didn't try to redownload it.
I recommand to change one character in the hash and update it with the hash retruned in the error

pkgs/tools/security/saml2aws/default.nix Show resolved Hide resolved
@pmyjavec pmyjavec changed the title Update default.nix saml2aws: 2.10.0 -> 2.15.0 Jul 11, 2019
@teto
Copy link
Member

teto commented Jul 11, 2019

@GrahamcOfBorg build saml2aws

@teto teto merged commit 95395fb into NixOS:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmyjavec @teto