Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytricia: unstable-2019-01-16 -> 1.0.0 #64470

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pytricia: unstable-2019-01-16 -> 1.0.0 #64470

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Updating "troubled" repology packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix path-info -Sh ./results/pytho*
/nix/store/s6wk8z69xnmh5i2wwbldw58nxrwid5gc-python2.7-pytricia-1.0.0      94.6M
/nix/store/wdsn2lv2khc6c9inzb04af6ph881wvq1-python3.7-pytricia-1.0.0      96.8M

$ nix-review wip
...
[1 built, 0.0 MiB DL]
2 package were build:
python27Packages.pytricia python37Packages.pytricia

@jonringer jonringer requested a review from FRidh as a code owner July 9, 2019 08:14
@FRidh
Copy link
Member

FRidh commented Jul 9, 2019

@GrahamcOfBorg build python3.pkgs.pytricia

@worldofpeace
Copy link
Contributor

this downgrades the package to jsommers/pytricia@c470d54 from jsommers/pytricia@4ba88f6.

I'm only guessing that someone added it with that version on purpose.

@jonringer
Copy link
Contributor Author

@worldofpeace that appears to be the case. Closing the ticket, not sure if I should submit a ticket in repology

@jonringer jonringer closed this Jul 13, 2019
@jonringer jonringer deleted the bump-pytricia branch December 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @FRidh @worldofpeace