Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: cleanup [[CanBlock]] tests #17688

Merged
merged 2 commits into from Jul 10, 2019
Merged

HTML: cleanup [[CanBlock]] tests #17688

merged 2 commits into from Jul 10, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Jul 9, 2019

(These do not require COOP/COEP treatment as they test SharedArrayBuffer on a single thread, but still seems nice to reduce clutter.)

(These do not require COOP/COEP treatment as they test SharedArrayBuffer on a single thread, but still seems nice to reduce clutter.)
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Nit: I think you can remove done() at the end of the files.

@annevk annevk merged commit e4b8a06 into master Jul 10, 2019
@annevk annevk deleted the annevk/html-canblock branch July 10, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants