Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elm.elmPackages: Update elm-analyse and node2nix #64486

Merged
merged 1 commit into from Jul 29, 2019
Merged

elm.elmPackages: Update elm-analyse and node2nix #64486

merged 1 commit into from Jul 29, 2019

Conversation

turboMaCk
Copy link
Member

Motivation for this change

Newer node2nix has fix for the issue that prevented latest elm-analyse version to be installed.

Things done
  1. Remove version constrain for elm-analyse
  2. run ./generate-node-packages.sh
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turboMaCk turboMaCk mentioned this pull request Jul 9, 2019
Merged
@domenkozar
Copy link
Member

cc @svanderburg

@turboMaCk
Copy link
Member Author

is there something I should do to increase probability of this being merged? I have no problem with investing more time to this.

@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages.elm-analyse

@domenkozar domenkozar merged commit 4df227f into NixOS:master Jul 29, 2019
@turboMaCk
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboMaCk @domenkozar