Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filezilla: 3.42.1 -> 3.43.0, libfilezilla: 0.16.0 -> 0.17.1 #64528

Merged
merged 2 commits into from Jul 14, 2019
Merged

filezilla: 3.42.1 -> 3.43.0, libfilezilla: 0.16.0 -> 0.17.1 #64528

merged 2 commits into from Jul 14, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 9, 2019 •
edited

Motivation for this change

Update filezilla and libfilezilla to the latest releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pSub July 9, 2019 15:24
@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 11, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build filezilla libfilezilla

@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 11, 2019

Hi, @worldofpeace, could you review this? Thank you very much!

@worldofpeace
Copy link
Contributor

Hi, @worldofpeace, could you review this? Thank you very much!

For sure, we're on a roll 😄

worldofpeace
worldofpeace approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the changelogs and built and launched filezilla

Seems to look good but I haven't tested the actually function.

@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 14, 2019

Hi @worldofpeace, thanks for the review.
I have tested the function and I can transfer files between remote servers and local system successfully.
Could we merge this PR?

@worldofpeace
Copy link
Contributor

Hi @worldofpeace, thanks for the review.
I have tested the function and I can transfer files between remote servers and local system successfully.
Could we merge this PR?

Sounds good to be me.

@worldofpeace worldofpeace merged commit 1a10f17 into NixOS:master Jul 14, 2019
@xrelkd xrelkd deleted the update/filezilla branch July 14, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @worldofpeace