Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dj-static: init at 0.0.6 #64527

Closed
wants to merge 1 commit into from

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Adding a missing Django package, including dependency static3 v0.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan
Copy link
Contributor Author

Quoted the URL and added tests, but there's an issue I can't figure out...
After the test session starts, the builder dies with the following message:
ERROR: file not found: tests :(

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@JohnAZoidberg
Copy link
Member

Do you still care about this package? Would you like to update the PR?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2022
@MrMebelMan
Copy link
Contributor Author

MrMebelMan commented Jun 6, 2022

@JohnAZoidberg, updated 👍

I haven't been able to fix static3 tests though :/

static3 (dependency): init at 0.7.0
Copy link
Contributor

@urandom2 urandom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you can split each derivation into a distinct commit, it can make the git log more readable

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/706

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing pythonImportsCheck. Also please do two commits, one for each package


propagatedBuildInputs = [ genshi ];

checkInputs = [ pytestCheckHook pytest-cov webtest ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checkInputs = [ pytestCheckHook pytest-cov webtest ];
checkInputs = [ pytestCheckHook webtest ];

we do not want to run coverage things. Please remove any setting with substituteInPlace that enable this.

sha256 = "1vz8ij123nhg5mhr8z0wzkjcq6pvlq2damp9wgk24yb16b2w2bh3";
};

doCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how do we check?

@mweinelt
Copy link
Member

mweinelt commented Jun 6, 2023

Superseded by dde0822 and 35f4603

@mweinelt mweinelt closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants