New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dj-static: init at 0.0.6 #64527
dj-static: init at 0.0.6 #64527
Conversation
352bc05
to
b46a56c
Compare
Quoted the URL and added tests, but there's an issue I can't figure out... |
b46a56c
to
dd91658
Compare
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Do you still care about this package? Would you like to update the PR? |
dd91658
to
0b405e9
Compare
@JohnAZoidberg, updated 👍 I haven't been able to fix static3 tests though :/ |
static3 (dependency): init at 0.7.0
0b405e9
to
058d3eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you can split each derivation into a distinct commit, it can make the git log more readable
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing pythonImportsCheck. Also please do two commits, one for each package
|
||
propagatedBuildInputs = [ genshi ]; | ||
|
||
checkInputs = [ pytestCheckHook pytest-cov webtest ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkInputs = [ pytestCheckHook pytest-cov webtest ]; | |
checkInputs = [ pytestCheckHook webtest ]; |
we do not want to run coverage things. Please remove any setting with substituteInPlace that enable this.
sha256 = "1vz8ij123nhg5mhr8z0wzkjcq6pvlq2damp9wgk24yb16b2w2bh3"; | ||
}; | ||
|
||
doCheck = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But how do we check?
Motivation for this change
Adding a missing Django package, including dependency static3 v0.7.0
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)