Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMIGEN_ overrides are incorrectly emitted in output scripts. #130

Closed
cr1901 opened this issue Jul 6, 2019 · 1 comment
Closed

NMIGEN_ overrides are incorrectly emitted in output scripts. #130

cr1901 opened this issue Jul 6, 2019 · 1 comment
Labels
bug platform:lattice-ecp5 platform:lattice-ice40 platform:xilinx-7series
Milestone
0.1

Comments

@cr1901
Copy link
Contributor

cr1901 commented Jul 6, 2019

Actual Behavior

Example:

William@William-THINK MINGW64 ~/src/migen_mercury
$ export NMIGEN_nextpnr_opts="--placer sa"

William@William-THINK MINGW64 ~/src/migen_mercury
$ python3 -m nmigen_boards.icebreaker

William@William-THINK MINGW64 ~/src/migen_mercury
$ cat build/build_top.bat
@rem Automatically generated by nMigen 2829d04-dirty. Do not edit.
@echo off
yosys -q -l top.rpt top.ys || exit /b
nextpnr-ice40 --quiet - - p l a c e r s a --log top.tim --up5k --package sg48 --json top.json --pcf top.pcf --pre-pack top_pre_pack.py --asc top.asc || exit /b
icepack top.asc top.bin || exit /b

The NMIGEN_nextpnr_opts variable is incorrectly expanded into - - p l a c e r s a in the output batch file. This behavior exists from a cmd.exe or an MSYS2 prompt.

Expected Behavior

The variable should be expanded into --placer sa. Per IRC, it appears to be due to how Jinja2 join(" ") is implemented?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug platform:lattice-ecp5 platform:lattice-ice40 platform:xilinx-7series
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@whitequark @cr1901