Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: Register a service worker just once for worker subresource interception tests #17675

Merged
merged 1 commit into from Aug 17, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This is a follow-up CL for the previous review comment:
https://chromium-review.googlesource.com/c/chromium/src/+/1683916/7/third_party/blink/web_tests/external/wpt/service-workers/service-worker/worker-interception.https.html#148

As a side effect, this fixes a failure of subresource interception on nested
dedicated workers that is caused by wrong service worker scope. See
https://chromium-review.googlesource.com/c/chromium/src/+/1683916/7/third_party/blink/web_tests/external/wpt/service-workers/service-worker/worker-interception.https.html#184

Bug: 731604, 906991
Change-Id: I4866d8a74e8b1e2695231b8c95a740923da8ceed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682440
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673987}

…terception tests

This is a follow-up CL for the previous review comment:
https://chromium-review.googlesource.com/c/chromium/src/+/1683916/7/third_party/blink/web_tests/external/wpt/service-workers/service-worker/worker-interception.https.html#148

As a side effect, this fixes a failure of subresource interception on nested
dedicated workers that is caused by wrong service worker scope. See
https://chromium-review.googlesource.com/c/chromium/src/+/1683916/7/third_party/blink/web_tests/external/wpt/service-workers/service-worker/worker-interception.https.html#184

Bug: 731604, 906991
Change-Id: I4866d8a74e8b1e2695231b8c95a740923da8ceed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682440
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673987}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@Hexcles
Copy link
Member

Hexcles commented Jul 9, 2019

@rakuco rakuco closed this Jul 22, 2019
@rakuco rakuco reopened this Jul 22, 2019
@rakuco rakuco closed this Jul 25, 2019
@rakuco rakuco reopened this Jul 25, 2019
@LukeZielinski
Copy link
Contributor

LukeZielinski commented Aug 1, 2019

Still seeing flakes here, a little different than the ones reported by Hexcles a while ago. Here are the current ones:

Unstable results

Test Subtest Results Messages
/service-workers/service-worker/worker-interception.https.html OK: 3/10, TIMEOUT: 7/10
/service-workers/service-worker/worker-interception.https.html Verify a cors worker script served by a service worker fails shared worker start. PASS: 5/10, TIMEOUT: 5/10 Test timed out
/service-workers/service-worker/worker-interception.https.html Verify a no-cors cross-origin worker script served by a service worker fails dedicated worker start. NOTRUN: 5/10, PASS: 5/10
/service-workers/service-worker/worker-interception.https.html Verify a no-cors cross-origin worker script served by a service worker fails shared worker start. NOTRUN: 5/10, PASS: 3/10, TIMEOUT: 2/10 Test timed out
/service-workers/service-worker/worker-interception.https.html Register a service worker for worker subresource interception tests. NOTRUN: 7/10, PASS: 3/10
/service-workers/service-worker/worker-interception.https.html Requests on a dedicated worker controlled by a service worker. FAIL: 3/10, NOTRUN: 7/10 assert_equals: expected "This load was successfully intercepted." but got "{\"error\": {\"message\": \"\", \"code\": 404}}"
/service-workers/service-worker/worker-interception.https.html Requests on a shared worker controlled by a service worker. NOTRUN: 7/10, PASS: 3/10
/service-workers/service-worker/worker-interception.https.html Requests on a dedicated worker nested in a dedicated worker and controlled by a service worker FAIL: 3/10, NOTRUN: 7/10 assert_equals: expected "This load was successfully intercepted." but got "{\"error\": {\"message\": \"\", \"code\": 404}}"
/service-workers/service-worker/worker-interception.https.html Requests on a dedicated worker nested in a shared worker and controlled by a service worker FAIL: 3/10, NOTRUN: 7/10 assert_equals: expected "This load was successfully intercepted." but got "Unexpected error! Worker is not defined"
/service-workers/service-worker/worker-interception.https.html Unregister a service worker for subresource interception tests. NOTRUN: 7/10, PASS: 3/10

@Hexcles Hexcles merged commit 0d26f05 into master Aug 17, 2019
@Hexcles Hexcles deleted the chromium-export-250461b340 branch August 17, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants