WIP: build-rust-crate: fix for binary crate building. #64385
Conversation
|
@miltador would you like to chime in on this pull request? |
See #64313. build-rust-crate used to always build a crate that had a source file with the same name as the crate as a library crate. This would break in the cases of the crate being a binary crate containing a source file with the same name, e.g. in xargo. Cargo used to erroneously allow a crate with the following contents in it's cargo toml: ```toml [lib] name = "foo" ``` having its main source file named `src/foo.rs`. This is behaviour that cargo warns about. This pull request is marked as WIP because the version of way-cooler that is in nixpkgs depends on an old version of the crate `c_vec` that assumed the erroneous behaviour of cargo. Unfortunately this pull request will make the build of way-cooler fail until the dependency is updated to a new version.
FRidh
requested review from
basvandijk,
edolstra,
Ericson2314,
FRidh,
infinisil,
matthewbauer,
nbp,
rycee and
thoughtpolice
as code owners
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
|
@dnaq Is this still required? |
stale
bot
removed
the
2.status: stale
|
I don’t think the issue has been fixed, it’s not a blocker for me personally, but some binary crates will still fail to build using buildRustCrate. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
See #64313.
build-rust-crate used to always build a crate that had a source file
with the same name as the crate as a library crate. This would break in
the cases of the crate being a binary crate containing a source file
with the same name, e.g. in xargo.
Cargo used to erroneously allow a crate with the following contents in it's cargo
toml:
having its main source file named
src/foo.rs. This is behaviour thatcargo warns about.
This pull request is marked as WIP because the version of way-cooler
that is in nixpkgs depends on an old version of the crate
c_vecthatassumed the erroneous behaviour of cargo. Unfortunately this pull
request will make the build of way-cooler fail until the dependency is
updated to a new version.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)