Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] graphicsmagick: 1.3.31 -> 1.3.32 (security release) #64402

Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 6, 2019

Motivation for this change

Cherrypick of #64380

I'm usually in favour of patching for stable branches, but the list of issues covered by this release would make that impractical: http://www.graphicsmagick.org/NEWS.html#june-15-2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

security release fixing numerous issues, darwin requires patch to fix issue
with pngs

(cherry picked from commit 9826490)
@grahamc
Copy link
Member

grahamc commented Jul 6, 2019

and a patch version update is nobig deal to backport usually :)

@risicle
Copy link
Contributor Author

risicle commented Jul 6, 2019

Yeah I would agree, but scroll down in the linked changelog and note how many "new features" and "feature improvements" this release includes. 😨

Ah well...

@grahamc grahamc merged commit 799a080 into NixOS:release-19.03 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants