Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.spacy: loosen dependency version bounds #64401

Merged
merged 1 commit into from Jul 11, 2019

Conversation

mattmelling
Copy link
Contributor

@mattmelling mattmelling commented Jul 6, 2019

Motivation for this change

python37Packages.spacy depends on 0.32.0,<0.33.0, but wheel has recently been updated to 0.33.4. This change removes the <0.33.0 restriction to allow compatibility with future versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mattmelling
Copy link
Contributor Author

I force pushed an update after somehow accidentally deleting a char between testing and committing - only noticed this evening during a rebuild while looking at another package. i hope this is OK.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title of PR and commit should be pythonPackages.spacy: .... I would do "loosen dependency version bounds" or something similar

this is what is mean by pkg-name in CONTRIBUTING

@mattmelling
Copy link
Contributor Author

@jonringer Thanks for the feedback. Should I amend the commit message and simply edit the PR title? Or would it be more appropriate to close and create a new PR to correct this?

@FRidh
Copy link
Member

FRidh commented Jul 10, 2019

Amend.

@jonringer
Copy link
Contributor

Sorry, i thought i replied to this. Yes, you should just amend an existing PR.

Plenty of people force push changes, so that the commit history looks nice on master. :)

@mattmelling mattmelling changed the title python: spacy: wheel>=0.32.0,<0.33.0 -> wheel>=0.32.0 pythonPackages.spacy: loosen dependency version bounds Jul 10, 2019
@mattmelling
Copy link
Contributor Author

Thanks for the feedback guys! :)

@FRidh FRidh merged commit 00898f0 into NixOS:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants