[Gecko Bug 1493907] [wptrunner] Expose headless flag for expected meta data. #17724
Conversation
wpt-pr-bot
added
infra
webdriver
wg-testing_browser
wptrunner
Differential Revision: https://phabricator.services.mozilla.com/D36723 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1493907 gecko-commit: 0609705a34727f7049ce2e97f214823031b5f703 gecko-integration-branch: central gecko-reviewers: webdriver-reviewers, ato
…ode. Differential Revision: https://phabricator.services.mozilla.com/D36725 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1493907 gecko-commit: d62f57d8e0b72ba75be5b50bb02d042ec2ace36c gecko-integration-branch: central gecko-reviewers: webdriver-reviewers, ato
moz-wptsync-bot
force-pushed
the
gecko/1493907
branch
from
a20272b
to
3974596
Compare
|
@whimboo This appears to be actually broken |
|
@jgraham what's the best option to get this fixed? A new follow-up bug in Bugzilla, but that might fail with a merge conflict. Or creating a new PR on that repository with all the fixes included? |
|
So the remaining taskcluster failures are expected because the failing tests are expected to fail due to remaining bugs in Firefox with headless mode. What I'm unclear about are the Azure pipeline failures. The failure here is:
I didn't touch any of that code, so I wonder if that is something we don't have to block on when merging this PR? @jgraham or @gsnedders does one of you know about that? |
|
That's not the failure, that's an expected error. https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=24714&view=logs&jobId=c092c851-ddde-53a1-8da2-b0c5715821df&taskId=47054073-909c-56ea-51bf-02a1df7e38a8&lineStart=445&lineEnd=446&colStart=1&colEnd=1 is the actual failure, which I think is an error in master because https://github.com/web-platform-tests/wpt/blob/master/infrastructure/metadata/infrastructure/testdriver/actions/actionsWithKeyPressed.html.ini should expect a mac failure on both Chrome and Firefox (I think that test fundamentally does something that doesn't make sense on mac and should be fixed). Would you mind updating that file here? |
|
The pull request for updating that file is already up here: https://github.com/web-platform-tests/wpt/pull/18031933724. So I assume that I don't have to do anything on that PR, and it only needs to be rebased against master? |
Differential Revision: https://phabricator.services.mozilla.com/D36723
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1493907
gecko-commit: 0609705a34727f7049ce2e97f214823031b5f703
gecko-integration-branch: central
gecko-reviewers: webdriver-reviewers, ato