Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freetype: 2.10.0 -> 2.10.1 #64513

Merged
merged 2 commits into from Jul 20, 2019
Merged

freetype: 2.10.0 -> 2.10.1 #64513

merged 2 commits into from Jul 20, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 9, 2019

Motivation for this change

https://sourceforge.net/projects/freetype/files/freetype2/2.10.1/

I've been experimenting with mini bootstrap to get freetype and harfbuzz
built with support for the other, as well as using freetype's default
(instead of "encumbered" cleartype) mostly to see what the state of
things were and for potentially avoiding any/all color fringing
without mucking with lcd filter settings.

This PR simply bumps the freetype version, don't worry :).
Not sure the bootstrap dance helps anything, but if anyone has
recent images/data/information on default ("Harmony"?) vs
"encumbered" cleartype that'd be appreciated.

I've been happy with Harmony so far, but maybe I'm not looking at the
right details or use different sorts of programs...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel July 9, 2019 13:50
@dtzWill
freetype: undo formatting, esp since doesn't move to convention.
f3381b5 
Sorry, thanks for catching this in review!

Leaving it as it was to keep this change simpler and
friendlier to blame and such :).
@FRidh
Copy link
Member

FRidh commented Jul 17, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build freetype

@ofborg ofborg bot requested a review from ttuegel July 17, 2019 08:48
@dtzWill dtzWill merged commit 63be588 into NixOS:staging Jul 20, 2019
@dtzWill dtzWill deleted the update/freetype-2.10.1 branch July 20, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @FRidh @ttuegel