Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django: Init at 2.0.2 #64518

Closed
wants to merge 1 commit into from
Closed

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Adding an older version of Django that is still being used in some projects.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 9, 2019

@MrMebelMan please put related commits in one PR but with separate commits. That makes it easier to review.

Note also that Django 2.0 won't be added back because it's EOL.

cc @lsix

@FRidh
Copy link
Member

FRidh commented Jul 9, 2019

Also, we prefer to have tests working. It's not always possible but give it a try. If it doesn't work, explain with a comment why not.

@MrMebelMan
Copy link
Contributor Author

@MrMebelMan please put related commits in one PR but with separate commits. That makes it easier to review.

Sure!

Also, we prefer to have tests working. It's not always possible but give it a try. If it doesn't work, explain with a comment why not.

I am just starting out with Nix and still unsure about how to run tests :)
I'll RTFM and update my other PRs, thank you. I guess, this one can be closed, since Django 2.0 is EOL?

@lsix
Copy link
Member

lsix commented Jul 9, 2019

Django-2.0 reached EOL on April 1, 2019 (c.f. https://www.djangoproject.com/download/). We still support 1.11, 2.1 and 2.2 (the 2.* being python3 only).

I close this PR and will have a look at the others later today.

And to be fair, none of the Django derivations are tested in nixpkgs since it would require stuff we do not have in isolated environments (such as databases servers). But yes, we could try to test what does not require those “impurities”. I guess the line in this PR was copied from existing derivations.

@lsix lsix closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants