Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

most: 5.0.0a -> 5.1.0 #64516

Merged
merged 1 commit into from Jul 12, 2019
Merged

most: 5.0.0a -> 5.1.0 #64516

merged 1 commit into from Jul 12, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 9, 2019 •
edited

Motivation for this change

Update most to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build most

@xrelkd
most: 5.0.0a -> 5.1.0
faf8420 
Fix source url
Note: There is no version 5.1.0 in "ftp://space.mit.edu/pub/davis/most/".
@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 12, 2019

Hi @worldofpeace, updated as your suggestions, thanks.

@worldofpeace worldofpeace merged commit 618be7d into NixOS:master Jul 12, 2019
@worldofpeace
Copy link
Contributor

Thanks to you too @xrelkd

@xrelkd xrelkd deleted the update/most branch July 13, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @worldofpeace