New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django-maintenance-mode: init at 0.13.1 #64520
django-maintenance-mode: init at 0.13.1 #64520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR,
I added comments in the review that should be addressed before merging.
mock, django }: | ||
buildPythonPackage rec { | ||
pname = "django-maintenance-mode"; | ||
version = "0.13.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://pypi.org/project/django-maintenance-mode/ there is a 0.13.3 version available. Any specific reason not to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not really, I am using it with an older version of django on one of my private projects... I'll bump it, sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sympathize with being stuck on older versions of e.g. django - is dropping support for older djangos a deliberate move in 0.13.3 by the project authors? If not, do let them know it's not working for you.
pkgs/development/python-modules/django-maintenance-mode/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-maintenance-mode/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-maintenance-mode/default.nix
Outdated
Show resolved
Hide resolved
42e1840
to
90bd022
Compare
bumped the version to |
pkgs/development/python-modules/django-maintenance-mode/default.nix
Outdated
Show resolved
Hide resolved
90bd022
to
8bdc066
Compare
@GrahamcOfBorg build django-maintenance-mode |
@MrMebelMan do you mind rebasing this? |
8bdc066
to
8879f3e
Compare
done! |
@GrahamcOfBorg build django-maintenance-mode |
Sorry, dropped the ball on this, do you mind rebasing again?:) |
And maybe updating to latest. |
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
8879f3e
to
91364bd
Compare
Sorry for the late reaction. Rebased master & updated django-maintenance-mode to the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 64520 1
2 packages built:
- python37Packages.django-maintenance-mode
- python38Packages.django-maintenance-mode
Motivation for this change
Adding a missing Django package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)