Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvmgt service: use modprobe, force-load module #64425

Merged
merged 1 commit into from Jul 8, 2019
Merged

kvmgt service: use modprobe, force-load module #64425

merged 1 commit into from Jul 8, 2019

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Jul 7, 2019

Motivation for this change

Force-load of kernel module was needed for my laptop for some reason. Also moved the kernel option to modprobe configuration - this is somewhat controversial, my reasoning is that options for modules should be there to avoid command line bloat and be a single source of truth.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @gnidorah

@ghost
Copy link

ghost commented Jul 8, 2019

@abbradar Interesting, thank you! Never had a need for any fix for my hardware, but if that helps you, I think its nice to have it merged

@abbradar abbradar merged commit 13b8156 into NixOS:master Jul 8, 2019
@ghost ghost mentioned this pull request Mar 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abbradar