Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.deap: 1.2.2 -> 1.3.0 #64434

Merged
merged 2 commits into from Jul 12, 2019
Merged

pythonPackages.deap: 1.2.2 -> 1.3.0 #64434

merged 2 commits into from Jul 12, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Just going through repology at this point and updating packages.

marked sklearn-deap as broken due to rsteca/sklearn-deap#65

pythonPackages.sklearn-deap still works because we fix it at the last supported version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner July 8, 2019 05:11
matthiasbeyer
matthiasbeyer approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good.

@teto
Copy link
Member

teto commented Jul 12, 2019

@GrahamcOfBorg build pythonPackages.deap

@teto teto merged commit a6e3081 into NixOS:master Jul 12, 2019
@jonringer jonringer deleted the bump-deap branch December 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @teto @matthiasbeyer