Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfitsio: 3.450 -> 3.47 #64474

Merged
merged 1 commit into from Jul 18, 2019
Merged

cfitsio: 3.450 -> 3.47 #64474

merged 1 commit into from Jul 18, 2019

Conversation

xbreak
Copy link
Contributor

@xbreak xbreak commented Jul 9, 2019

Motivation for this change
  • Update to latest release, skipping 3.460. See also changelog.
Things done
  • Use version number without trailing '0'
  • Disable format hardening since it broke the build.
  • Remove the now obsolete (from what I understand) patch darwin-curl-config.patch (I need help testing this on Darwin).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested on CentOS 7.4:

  • cfitsio
  • ufraw (currently broken on master)
  • indilib
  • gildas
  • giv (manual testing by loading fits-files)

@smaret
Copy link
Member

smaret commented Jul 9, 2019

Built successfully on Darwin with nix-review pr. It looks good to me.

* changed to version numbering without trailing '0'
* remove obsolete `darwin-curl-config.patch`
* disable format hardening to fix build
@xbreak xbreak changed the title cfitsio: 3.450 -> 3.470 cfitsio: 3.450 -> 3.47 Jul 17, 2019
@dywedir
Copy link
Member

dywedir commented Jul 18, 2019

Thanks!

@dywedir dywedir merged commit 9bda7eb into NixOS:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants