Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klavaro: 3.08 -> 3.09, patch format-string, espeak support #64488

Closed
wants to merge 1 commit into from
Closed

klavaro: 3.08 -> 3.09, patch format-string, espeak support #64488

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace reviewed Jul 13, 2019
View reviewed changes
pkgs/games/klavaro/default.nix
};

nativeBuildInputs = [ intltool makeWrapper pkgconfig ];
buildInputs = [ curl gtk3 ];

patches = [ (builtins.toFile "format-string" ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you think this is a rather, interesting way to patch things?
Is this your patch @dtzWill?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is mine :). I like having small patch inline but can of course move to a separate file if preferred?

worldofpeace
worldofpeace reviewed Jul 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified everything executes and inspected that the patchPhase is doing things properly. (ran manually).

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@infinisil
Copy link
Member

klavaro was updated to 3.10 in #89352, which seems to not need the format patch anymore. But the espeak one would still be nice. Can you update this PR for that? I'll merge it then.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 22, 2020
@stale
Copy link

stale bot commented Feb 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 21, 2021
@dtzWill
Copy link
Member Author

dtzWill commented Jul 9, 2021

Closing, will submit espeak fixup in separate PR (and I think bump as well, actually) :).

@dtzWill dtzWill closed this Jul 9, 2021
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 14, 2022
@dtzWill
klavaro: 3.11 -> 3.13, espeak support
65eed88 
* espeak fixup from NixOS#64488
* gtkdatabox
gador pushed a commit to gador/nixpkgs that referenced this pull request Mar 15, 2022
@dtzWill @gador
klavaro: 3.11 -> 3.13, espeak support
81f10f4 
* espeak fixup from NixOS#64488
* gtkdatabox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @infinisil @worldofpeace @alyssais